feat(websocket): add ability to remove listener

Change listeners array to use a set instead, which prevents addition of duplicated listeners which could possibly lead to memory leaks.
pull/2027/head
Twilight 9 months ago committed by GitHub
parent b2aea04567
commit 6a090f63ab
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -32,9 +32,9 @@ export type Message =
export default class WebSocket {
id: number
private readonly listeners: Array<(arg: Message) => void>
private readonly listeners: Set<(arg: Message) => void>
constructor(id: number, listeners: Array<(arg: Message) => void>) {
constructor(id: number, listeners: Set<(arg: Message) => void>) {
this.id = id
this.listeners = listeners
}
@ -43,7 +43,7 @@ export default class WebSocket {
url: string,
config?: ConnectionConfig
): Promise<WebSocket> {
const listeners: Array<(arg: Message) => void> = []
const listeners: Set<(arg: Message) => void> = new Set()
const onMessage = new Channel<Message>()
onMessage.onmessage = (message: Message): void => {
@ -63,8 +63,12 @@ export default class WebSocket {
}).then((id) => new WebSocket(id, listeners))
}
addListener(cb: (arg: Message) => void): void {
this.listeners.push(cb)
addListener(cb: (arg: Message) => void): () => void {
this.listeners.add(cb)
return () => {
this.listeners.delete(cb)
}
}
async send(message: Message | string | number[]): Promise<void> {

Loading…
Cancel
Save