From 7327602f151b90ed38cbedcbac3812a14ff2ae01 Mon Sep 17 00:00:00 2001
From: Tony <68118705+Legend-Master@users.noreply.github.com>
Date: Mon, 27 May 2024 23:31:58 +0800
Subject: [PATCH] chore(updater): remove `/NS` (#1371)

---
 plugins/updater/src/config.rs  | 3 +++
 plugins/updater/src/updater.rs | 1 -
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/plugins/updater/src/config.rs b/plugins/updater/src/config.rs
index 01238760..757a5349 100644
--- a/plugins/updater/src/config.rs
+++ b/plugins/updater/src/config.rs
@@ -32,6 +32,9 @@ impl WindowsUpdateInstallMode {
 
     /// Returns the associated nsis arguments.
     pub fn nsis_args(&self) -> &'static [&'static str] {
+        // `/P`: Passive
+        // `/S`: Silent
+        // `/R`: Restart
         match self {
             Self::Passive => &["/P", "/R"],
             Self::Quiet => &["/S", "/R"],
diff --git a/plugins/updater/src/updater.rs b/plugins/updater/src/updater.rs
index ebc0e694..9c794717 100644
--- a/plugins/updater/src/updater.rs
+++ b/plugins/updater/src/updater.rs
@@ -556,7 +556,6 @@ impl Update {
         match updater_type {
             WindowsUpdaterType::Nsis => {
                 installer_args.extend(install_mode.nsis_args().iter().map(OsStr::new));
-                installer_args.push(OsStr::new("/NS"));
                 installer_args.push(OsStr::new("/UPDATE"));
             }
             WindowsUpdaterType::Msi => {