From c81dff292afc9e9f52470a8d9e34b5a00c14b3a0 Mon Sep 17 00:00:00 2001 From: Amr Bashir Date: Sun, 18 Jun 2023 13:18:20 +0300 Subject: [PATCH] fix(notification): remove default notification sound on Windows (#440) --- .changes/notification-revert-sound.md | 5 +++++ plugins/notification/src/desktop.rs | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 .changes/notification-revert-sound.md diff --git a/.changes/notification-revert-sound.md b/.changes/notification-revert-sound.md new file mode 100644 index 00000000..b21cb9a6 --- /dev/null +++ b/.changes/notification-revert-sound.md @@ -0,0 +1,5 @@ +--- +"notification": patch +--- + +Revert [7d71ad4e5](https://github.com/tauri-apps/plugins-workspace/commit/7d71ad4e587bcf47ea34645f5b226945e487b765) which added a default sound for notifications on Windows. This introduced inconsistency with other platforms that has silent notifications by default. In the upcoming releases, we will add support for modifying the notification sound across all platforms. diff --git a/plugins/notification/src/desktop.rs b/plugins/notification/src/desktop.rs index 401f6569..897790f0 100644 --- a/plugins/notification/src/desktop.rs +++ b/plugins/notification/src/desktop.rs @@ -184,9 +184,6 @@ mod imp { { notification.app_id(&self.identifier); } - - // will be parsed as a `::winrt_notification::Sound` - notification.sound_name("Default"); } #[cfg(target_os = "macos")] {