Apply suggestions from code review

Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
pull/1860/head
Tony 8 months ago committed by GitHub
parent 3f470a7a67
commit 5296ffa3de
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -3,5 +3,5 @@
--- ---
- Add `getStore` - Add `getStore`
- Add an option to use pre-stored (de)serialize functions - Add an option to use pre-stored (de)serialize functions (registered on rust)
- Add back lazy store `LazyStore` - Add `LazyStore`

@ -2,13 +2,13 @@
"store": minor:breaking "store": minor:breaking
--- ---
**Breaking changes**: ### Breaking changes:
- Renamed `StoreCollection` to `StoreState` - Renamed `StoreCollection` to `StoreState`
- `StoreBuilder::build` now returns a `Result` - `StoreBuilder::build` now returns a `Result`
- `StoreExt::store` now returns `Result<Arc<Store>>` - `StoreExt::store` now returns `Result<Arc<Store>>`
Other Changes: ### Enhancements:
- Save and cancel pending auto save on drop - Save and cancel pending auto save on drop
- Use absolute path as store's key, fix #984 - Use absolute path as store's key, fix #984
@ -16,9 +16,9 @@ Other Changes:
- Enable auto save with 100ms debounce time by default - Enable auto save with 100ms debounce time by default
- Use pretty json by default, close #1690 - Use pretty json by default, close #1690
New features: ### New features:
- Add `getStore`/`get_store` share stores across js and rust side - Add `get_store` to get shared stores across js and rust side
- Add default (de)serialize functions settings - Add default (de)serialize functions settings
- Allow js to use pre-stored (de)serialize functions - Allow js to use pre-stored (de)serialize functions
- Add back lazy store (implemented in js) - Add back lazy store (implemented in js)

Loading…
Cancel
Save