fix(updater): Use escaped installer path to start the msi updater (#728)

* fix(updater): Use escaped installer path to start the msi updater

Continuation of #727

* change file

* fix build
pull/731/head
Amr Bashir 2 years ago committed by GitHub
parent 9db40a6dc4
commit a3ca64275a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -2,4 +2,4 @@
updater: patch updater: patch
--- ---
Use escaped installer path to start the nsis updater to prevent crashes if app name contained spaces. Use escaped installer path to start the nsis/msi updater to prevent crashes if app name contained spaces.

@ -551,7 +551,7 @@ impl Update {
"-ArgumentList", "-ArgumentList",
]) ])
.arg("/i,") .arg("/i,")
.arg(msi_path_arg) .arg(&msi_path_arg)
.arg(format!(", {}, /promptrestart;", msiexec_args.join(", "))) .arg(format!(", {}, /promptrestart;", msiexec_args.join(", ")))
.arg("Start-Process") .arg("Start-Process")
.arg(current_exe_arg) .arg(current_exe_arg)
@ -565,7 +565,7 @@ impl Update {
); );
let _ = Command::new(msiexec_path) let _ = Command::new(msiexec_path)
.arg("/i") .arg("/i")
.arg(found_path) .arg(msi_path_arg)
.args(msiexec_args) .args(msiexec_args)
.arg("/promptrestart") .arg("/promptrestart")
.spawn(); .spawn();

Loading…
Cancel
Save