chore(updater): remove `/NS` (#1371)

pull/1378/head
Tony 1 year ago committed by GitHub
parent b0518206cd
commit 7327602f15
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -32,6 +32,9 @@ impl WindowsUpdateInstallMode {
/// Returns the associated nsis arguments. /// Returns the associated nsis arguments.
pub fn nsis_args(&self) -> &'static [&'static str] { pub fn nsis_args(&self) -> &'static [&'static str] {
// `/P`: Passive
// `/S`: Silent
// `/R`: Restart
match self { match self {
Self::Passive => &["/P", "/R"], Self::Passive => &["/P", "/R"],
Self::Quiet => &["/S", "/R"], Self::Quiet => &["/S", "/R"],

@ -556,7 +556,6 @@ impl Update {
match updater_type { match updater_type {
WindowsUpdaterType::Nsis => { WindowsUpdaterType::Nsis => {
installer_args.extend(install_mode.nsis_args().iter().map(OsStr::new)); installer_args.extend(install_mode.nsis_args().iter().map(OsStr::new));
installer_args.push(OsStr::new("/NS"));
installer_args.push(OsStr::new("/UPDATE")); installer_args.push(OsStr::new("/UPDATE"));
} }
WindowsUpdaterType::Msi => { WindowsUpdaterType::Msi => {

Loading…
Cancel
Save